Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

177 improve annotation mapping through readgmt #202

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

axelklenk
Copy link
Collaborator

This PR contains the following:

  • the annotation slot in all parameter objects is no longer a simple character (containing the name of an annotation package) but a GSEABase::GeneIdentifierType object
  • it can be set using the annotation argument of the parameter object's constructor (that eventually has a use)
    • if NULL it will be attempted to use the expression data set's gene identifier type (or, in other words, the gene identifier type provided at parameter object construction time overrides that of the expression data set)
    • otherwise it will be set to NullIdentifier() -- a parameter object must not contain a NULL gene identifier type
  • documentation update describing the above
  • more general overhaul of the documentation of parameter object classes and constructors

It does not yet contain (to be done): gene identifier mapping for container-less expression data sets (matrix and dgCMatrix) and gene sets (list of character)

@axelklenk axelklenk self-assigned this Sep 23, 2024
@axelklenk axelklenk merged commit e04d41e into devel Sep 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant