Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Dockerfile's getDirective() with getDirectives() #64

Closed
rcjsuen opened this issue Dec 7, 2019 · 0 comments
Closed

Replace Dockerfile's getDirective() with getDirectives() #64

rcjsuen opened this issue Dec 7, 2019 · 0 comments
Assignees
@rcjsuen
Labels
enhancement

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Dec 7, 2019

Although it will take some time to fully implement #62, we should at least deprecate getDirective() and add getDirectives() to the API in the meantime.
@rcjsuen rcjsuen closed this as completed in daa28b7 Dec 7, 2019
rcjsuen added a commit that referenced this issue Dec 7, 2019
@rcjsuen
Fix #64 Fix getDirectives() to return an empty array
043022b 
If a Dockerfile had no parser directives, Dockerfile's getDirectives()
was still returning an array with a null inside of it. This has been
fixed to now return an empty array.

Signed-off-by: Remy Suen <[email protected]>
@rcjsuen rcjsuen self-assigned this Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen