Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

! upgrade riscv demo rust-toolchain's version to nightly #117

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lispking
Copy link

@lispking lispking commented Nov 6, 2023

rt

nightly
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any chance we can get this onto a stable toolchain?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stable branch will report an error because linked_list_allocator unsupported stable.

Compiling linked_list_allocator v0.9.1
error[E0554]: `#![feature]` may not be used on the stable release channel
1 | #![cfg_attr(feature = "const_mut_refs", feature(const_mut_refs))]

Check if the dependency count is older for packages that rely on opensbi-rt

Another interesting thing is that this library doesn't seem to be officially planned for maintenance anymore?

https://os.phil-opp.com/kernel-heap/

cargo tree

├── opensbi-rt v0.1.0 (https://github.com/rcore-os/opensbi-rt.git?rev=abdfeb72#abdfeb72)
│   ├── **linked_list_allocator v0.9.1**
│   │   └── spinning_top v0.2.5
│   │       └── lock_api v0.4.11
│   │           └── scopeguard v1.2.0
│   │           [build-dependencies]
│   │           └── autocfg v1.1.0
│   ├── log v0.4.20
│   └── spin v0.9.8
│       └── lock_api v0.4.11 (*)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could look into using buddy_system_allocator, as in the aarch64 example. However, that doesn't need to block merging this PR, I'm happy to merge once the presubmit checks and fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants