Support size and emergency write features on VirtIOConsole #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwandor
force-pushed
the
console_features
branch
from
64a8a3c
to
bd60d67
Compare
console_info wasn't checking supported features before reading the config space, and max_ports isn't much use when the driving doesn't support multiple ports.
qwandor
force-pushed
the
console_features
branch
from
bd60d67
to
5532ae3
Compare
qwandor
force-pushed
the
console_features
branch
from
7be950d
to
56ec0da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've replaced the
infomethod with a new methodsize, which properly checks the supported features before reading the config space. There wasn't much point readingmax_portswhen the driver doesn't support multiple ports anyway.