Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiled-grammar.js is strict mode compatible #26

Merged
merged 2 commits into from
Apr 18, 2017
Merged

compiled-grammar.js is strict mode compatible #26

merged 2 commits into from
Apr 18, 2017

Conversation

download13
Copy link
Contributor

Fixes #25

@download13 download13 mentioned this pull request Apr 8, 2017
Closed
@rcs
Copy link
Owner

rcs commented Apr 17, 2017

Thanks for this.

Looks like jison isn't gonna update quickly.

Would you mind adding a comment referencing zaach/jison#351 / zaach/jison#352 ?

@download13
Copy link
Contributor Author

You meant code comments right?

@rcs
Copy link
Owner

rcs commented Apr 18, 2017

Yup. Thank you.

@rcs rcs merged commit 12f4077 into rcs:master Apr 18, 2017
@Glavin001 Glavin001 mentioned this pull request May 30, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@download13 @rcs