Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Django 4.2 #223

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Conversation

waleoyediran
Copy link
Contributor

Bump the django version requirements to 4.2
Include test configuration for django 4.2

@pfcodes
Copy link

pfcodes commented Jun 2, 2023

Please merge

@waleoyediran
Copy link
Contributor Author

Hi @pfcodes I dont have write access to merge.
Can you do it instead?

@pfcodes
Copy link

pfcodes commented Jun 2, 2023

Hi @pfcodes I dont have write access to merge.
Can you do it instead?

That was an open message meant to be seen by a maintainer. I don't have access either. Also this PR needs one more change in setup.py:

django_python_version_install = "Django>=4.0,<4.2"

should be changed to

django_python_version_install = "Django>=4.0,<4.3"

or the resolution error still happens

@jheld
Copy link
Collaborator

jheld commented Jun 12, 2023

Hi @pfcodes I dont have write access to merge.
Can you do it instead?

That was an open message meant to be seen by a maintainer. I don't have access either. Also this PR needs one more change in setup.py:

django_python_version_install = "Django>=4.0,<4.2"

should be changed to

django_python_version_install = "Django>=4.0,<4.3"

or the resolution error still happens

Hi all, agreed we will need that variable adjusted, too.

@nickmccullum nickmccullum mentioned this pull request Jun 13, 2023
@waleoyediran
Copy link
Contributor Author

Should be good to merge now.

@jheld jheld merged commit 6f4417d into rdegges:develop Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants