Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 5 support #239

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Django 5 support #239

merged 1 commit into from
Mar 19, 2024

Conversation

nickmccullum
Copy link
Contributor

I've installed this fork into my app by adding the following line to my requirements.txt file:

django-twilio @ git+https://github.com/nickmccullum/django-twilio@781504488503a7ee1026fcc0f91e6adc8f169faa

Our unit test suite is passing with this new version, which is a good sign. I'll run it in production starting today and let you know if I have any issues.

@nickmccullum
Copy link
Contributor Author

Once this is merged and a new PyPI package is released, feel free to close issue #238

@jheld
Copy link
Collaborator

jheld commented Mar 18, 2024

Thank you for the PR and am looking forward to the go-ahead on merge!

@nickmccullum
Copy link
Contributor Author

It's been running in production now for >24 hours and has sent many SMS 2FA messages. I think you're safe to merge and cut a release.

@jheld jheld merged commit 1c8f8c1 into rdegges:master Mar 19, 2024
13 checks passed
@calebsyring calebsyring mentioned this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants