feat: Implement RDF/JS dataset specification #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeswr
commented
Jul 28, 2024
Comment on lines
+821
to
+823
| difference(other) { | ||
| return this.filter(quad => !other.has(quad)); | ||
| } |
There was a problem hiding this comment.
There is lots of room for optimisation here; in particular, whenever other is also an N3Store and they share an index we can just merge / diff / compare the indices for set operations.
Would be worth opening up an issue to do this once this PR is merged.
TallTed
suggested changes
Jul 29, 2024
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
|
🎉 This PR is included in version 1.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to add full functionality of https://github.com/rdfjs/types/blob/master/dataset.d.ts. Observe that we alter the behavior of
#emptyon the empty set to now returntrueinstead offalse, as described in #391 - so it may be that this needs to be an mver bump.Supercedes #288, pushing to a branch on the N3.js repo so CI will run.
Closes #390
Closes #391