This repository has been archived by the owner on Mar 7, 2024. It is now read-only.
Fixes for windows & enable in CI #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Carnegie <[email protected]>
|
@kipz - Thank you for you PR! 🙏 We've been focusing on building up a volume of tests that we really missed ensuring they work properly for windows. |
|
Hey, @kipz, Do you mind opening the same PR against https://github.com/theupdateframework/go-tuf/tree/master? Since we've just moved the code to go-tuf, I'm probably going to archive this repository in the next few weeks so people know it's being deprecated in favour of https://github.com/theupdateframework/go-tuf/tree/master? |
|
As requested: theupdateframework/go-tuf#586 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since windows tests were disabled, it looks like we've drifted a bit and introduced a few issues preventing the tests from passing and from the project working on windows: