Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse component is not accessible friend #83

Closed
kossel opened this issue Feb 6, 2018 · 4 comments
Closed

Collapse component is not accessible friend #83

kossel opened this issue Feb 6, 2018 · 4 comments

Comments

@kossel
Copy link
Contributor

kossel commented Feb 6, 2018 •
edited
Loading

Even there are some aria attributes, it still missing tabIndex="0" attributes and some keyPress event handling. So you can not navigate, collapse or expand the tabs using keyboard only.

Please have a look at
https://springload.github.io/react-accessible-accordion/

vs

http://react-component.github.io/collapse/examples/simple.html

I think can PR if you accept this feature
@yesmeck
Copy link
Member

yesmeck commented Feb 7, 2018

Ref ant-design/ant-design#6017

@kossel Welcome PR

@kossel
Copy link
Contributor Author

kossel commented Feb 7, 2018

Just want to make sure, looks like it can be done from rc-collapse or antd, where should I PR?

@yesmeck
Copy link
Member

yesmeck commented Feb 7, 2018

rc-collapse

@yesmeck
Copy link
Member

yesmeck commented Feb 7, 2018

antd is based on rc-collapse

@afc163 afc163 mentioned this issue Apr 2, 2018
Merged
@afc163 afc163 closed this as completed Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yesmeck @afc163 @kossel