Add keyboard support. #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afc163
reviewed
Feb 8, 2018
src/Panel.jsx
Outdated
| this.handleItemClick = this.handleItemClick.bind(this); | ||
| this.handleKeyPress = this.handleKeyPress.bind(this); | ||
| } | ||
|
|
||
| handleItemClick() { |
There was a problem hiding this comment.
Try handleItemClick = () => { instead of binding in constructor.
afc163
reviewed
Feb 8, 2018
| @@ -35,12 +49,14 @@ class CollapsePanel extends Component { | |||
| [`${prefixCls}-item-disabled`]: disabled, | |||
| }, className); | |||
| return ( | |||
| <div className={itemCls} style={style} id={id} role="tablist"> | |||
There was a problem hiding this comment.
I just moved it down to an inner div, since what we want to focus would be the header instead of the whole panel.
|
@afc163 实际使用起来的效果可以找 九向 review 一下。 |
|
what happen to this PR? |
|
is this going to be merged? |
afc163
reviewed
Apr 2, 2018
src/Panel.jsx
Outdated
| @@ -35,12 +43,14 @@ class CollapsePanel extends Component { | |||
| [`${prefixCls}-item-disabled`]: disabled, | |||
| }, className); | |||
| return ( | |||
| <div className={itemCls} style={style} id={id} role="tablist"> | |||
| <div className={itemCls} style={style} id={id} > | |||
|
close #83 |
afc163
added a commit
that referenced
this pull request
Apr 2, 2018
|
1.9.0 bumped |
|
Hi, I'm having issues with redux-form Field component passed to "header" prop of Panel component. I can delete characters in the input but I can't write. Working in rc-collapse 1.8.0 but not in 1.9.0. How should we proceed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not very familiar with testing, can you have a look and let me know it this works?