Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use father and fix lint #287

Merged
merged 15 commits into from
Oct 11, 2019
Merged

chore: Use father and fix lint #287

merged 15 commits into from
Oct 11, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Oct 11, 2019

Seems this can be done before 4.0.

Mainly Change

  • Use father & fix lint
  • (!) Divider change to function component
  • (!) util use import isMobile instead of require

@vercel
Copy link

vercel bot commented Oct 11, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/menu/j5ny40mct
🌍 Preview: https://menu-git-new-trigger.react-component.now.sh

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@c60ad47). Click here to learn what that means.
The diff coverage is 94.59%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #287   +/-   ##
=========================================
  Coverage          ?   95.03%           
=========================================
  Files             ?       10           
  Lines             ?      786           
  Branches          ?      230           
=========================================
  Hits              ?      747           
  Misses            ?       39           
  Partials          ?        0
Impacted Files Coverage Δ
src/MenuItemGroup.jsx 100% <ø> (ø)
src/Divider.jsx 100% <100%> (ø)
src/MenuItem.jsx 98.78% <100%> (ø)
src/Menu.jsx 97.64% <100%> (ø)
src/DOMWrap.jsx 85.07% <100%> (ø)
src/util.js 95.34% <100%> (ø)
src/SubPopupMenu.jsx 96.27% <100%> (ø)
src/SubMenu.jsx 97.94% <89.47%> (ø)
src/utils/isMobile.ts 93.75% <93.75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c60ad47...1454207. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant