Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Convert into TS #289

Merged
merged 10 commits into from
Oct 12, 2019
Merged

chore: Convert into TS #289

merged 10 commits into from
Oct 12, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Oct 12, 2019

Use Typescript for new life cycle method preparing.

@vercel
Copy link

vercel bot commented Oct 12, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/menu/5yrf7wxhd
🌍 Preview: https://menu-git-ts.react-component.now.sh

@zombieJ zombieJ requested a review from afc163 October 12, 2019 06:26
@codecov
Copy link

codecov bot commented Oct 12, 2019

Codecov Report

Merging #289 into master will increase coverage by 0.01%.
The diff coverage is 99.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
+ Coverage   95.03%   95.05%   +0.01%     
==========================================
  Files          10       10              
  Lines         786      788       +2     
  Branches      230      230              
==========================================
+ Hits          747      749       +2     
  Misses         39       39
Impacted Files Coverage Δ
src/placements.ts 100% <ø> (ø)
src/MenuItem.tsx 98.78% <100%> (ø)
src/MenuItemGroup.tsx 100% <100%> (ø)
src/SubPopupMenu.tsx 96.31% <100%> (ø)
src/SubMenu.tsx 97.95% <100%> (ø)
src/util.ts 95.45% <100%> (ø)
src/Menu.tsx 97.61% <100%> (ø)
src/Divider.tsx 100% <100%> (ø)
src/DOMWrap.tsx 85.18% <97.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcfbfb3...f70a891. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant