Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reafctor: Use CSSMotion #290

Merged
merged 10 commits into from
Oct 14, 2019
Merged

reafctor: Use CSSMotion #290

merged 10 commits into from
Oct 14, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Oct 13, 2019

No description provided.

@vercel
Copy link

vercel bot commented Oct 13, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/menu/1dehq8hbc
🌍 Preview: https://menu-git-motion.react-component.now.sh

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 13, 2019

This pull request introduces 1 alert when merging faf59eb into 58aab1a - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Oct 13, 2019

Codecov Report

Merging #290 into master will decrease coverage by 1.07%.
The diff coverage is 86.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
- Coverage   95.05%   93.97%   -1.08%     
==========================================
  Files          10       11       +1     
  Lines         788      797       +9     
  Branches      230      233       +3     
==========================================
  Hits          749      749              
- Misses         39       48       +9
Impacted Files Coverage Δ
src/util.ts 95.45% <ø> (ø) ⬆️
src/DOMWrap.tsx 84.96% <ø> (-0.23%) ⬇️
src/Menu.tsx 90.69% <100%> (-6.93%) ⬇️
src/SubMenu.tsx 97.91% <100%> (-0.05%) ⬇️
src/SubPopupMenu.tsx 95.18% <66.66%> (-1.14%) ⬇️
src/utils/legacyUtil.ts 90% <90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58aab1a...9418bda. Read the comment docs.

@zombieJ
Copy link
Member Author

zombieJ commented Oct 13, 2019

https://github.com/react-component/menu/pull/290/files#diff-6a815b35e7450c06c65064575bb218bdR193
内部通过 shouldComponentUpdate 判断是否跳过更新,而外部的 SubMenu 和 Animate 都通过直接设置 DOM style 更新动画,加了一些判断条件,但是感觉会有坑 😂

@zombieJ zombieJ merged commit 856137b into master Oct 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the motion branch October 14, 2019 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant