Fixed group and submenu focus #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #671 +/- ##
=======================================
Coverage 99.57% 99.58%
=======================================
Files 27 27
Lines 713 718 +5
Branches 192 193 +1
=======================================
+ Hits 710 715 +5
Misses 3 3 ☔ View full report in Codecov by Sentry. |
Ke1sy
commented
Nov 20, 2023
Ke1sy
changed the title
MadCcc
reviewed
Nov 22, 2023
|
@MadCcc I added fixes, please take a look. Thanks! |
|
Rebase once for rerun ci please. |
|
@yoyo837 can we merge it? |
yoyo837
approved these changes
Nov 30, 2023
|
Thanks for your contribution. |
This was referenced Dec 5, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix focus for when the first menu is a group/sub-menu. The issue is with shouldFocusKey calculation, it should skip grouping since it is not focusable.
Related ticket: ant-design/ant-design#45367
fix ant-design/ant-design#45367
close #669