Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Range prop step to be null in Typescript #757

Merged

Conversation

jnachtigall
Copy link
Contributor

This is the same like #691 where it was fixed for Slider but Range seems to have been forgotten. Fixes #739 #652 #574

This is the same like react-component#691 where it was fixed for `Slider` but `Range` seems to have been forgotten. Fixes react-component#739 react-component#652 react-component#574
@vercel
Copy link

vercel bot commented Mar 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/slider/4XiWdkNcS8zr3ueX3twniaUaKXpW
✅ Preview: https://slider-git-fork-jnachtigall-allowrangesteppropto-d28ee8.vercel.app

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #757 (2ac1681) into master (b959281) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 2ac1681 differs from pull request most recent head df0fe28. Consider uploading reports for the commit df0fe28 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #757   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files          11       11           
  Lines         756      756           
  Branches      199      198    -1     
=======================================
  Hits          669      669           
  Misses         87       87           
Impacted Files Coverage Δ
src/Range.tsx 77.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b959281...df0fe28. Read the comment docs.

@afc163 afc163 merged commit 683a818 into react-component:master Mar 25, 2021
@jnachtigall jnachtigall deleted the allow_range_step_prop_to_be_null branch March 25, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should be able to set step at null in a Range like in a Slider
2 participants