Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow callback for "dotStyle" and "activeDotStyle" props - with tests #830

Merged

Conversation

yann-combarnous
Copy link
Contributor

@yann-combarnous yann-combarnous commented Apr 28, 2022

Same as PR #828, but with added tests.

  • updated README
  • updated typescript typedefs
  • added callback option for the "dotStyle" and "activeDotStyle" props
  • added tests

close #828

@vercel
Copy link

vercel bot commented Apr 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
slider ✅ Ready (Inspect) Visit Preview Jun 15, 2022 at 7:11AM (UTC)

@yann-combarnous
Copy link
Contributor Author

@yoyo837 , I re-opened this PR, with tests added, even though I cannot run them on my system.

@yann-combarnous
Copy link
Contributor Author

@yoyo837 , used the same test syntax as in other tests now: expect(...).toHaveStyle. Hopefully tests should pass now :).

@yann-combarnous
Copy link
Contributor Author

@yoyo837 , fixed the actual/expected values, please allow the tests to run. Thx.

@yoyo837
Copy link
Member

yoyo837 commented Jun 15, 2022

CI failed.

@yann-combarnous
Copy link
Contributor Author

CI failed.

Yep, but first test passed (container1), so now I fixed offset for second test (container2). Sorry for the iterations, a bit difficult to get right without being able to run the tests locally.

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #830 (58102a1) into master (410717a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #830   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          13       13           
  Lines         533      535    +2     
  Branches      135      148   +13     
=======================================
+ Hits          532      534    +2     
  Misses          1        1           
Impacted Files Coverage Δ
src/Slider.tsx 100.00% <ø> (ø)
src/Steps/index.tsx 100.00% <ø> (ø)
src/Steps/Dot.tsx 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yoyo837 yoyo837 merged commit b50dbed into react-component:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants