-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow callback for "dotStyle" and "activeDotStyle" props - with tests #830
Allow callback for "dotStyle" and "activeDotStyle" props - with tests #830
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@yoyo837 , I re-opened this PR, with tests added, even though I cannot run them on my system. |
@yoyo837 , used the same test syntax as in other tests now: |
@yoyo837 , fixed the actual/expected values, please allow the tests to run. Thx. |
CI failed. |
Yep, but first test passed (container1), so now I fixed offset for second test (container2). Sorry for the iterations, a bit difficult to get right without being able to run the tests locally. |
Codecov Report
@@ Coverage Diff @@
## master #830 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 13 13
Lines 533 535 +2
Branches 135 148 +13
=======================================
+ Hits 532 534 +2
Misses 1 1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Same as PR #828, but with added tests.
close #828