refactor: add validNumberValue

react-component · Aug 25, 2024 · 14ecd3e · 14ecd3e
1 parent b004d1a
commit 14ecd3e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/Table.tsx b/src/Table.tsx
@@ -74,7 +74,7 @@ import Panel from './Panel';
 import StickyScrollBar from './stickyScrollBar';
 import Column from './sugar/Column';
 import ColumnGroup from './sugar/ColumnGroup';
-import { getColumnsKey, validateValue } from './utils/valueUtil';
+import { getColumnsKey, validateValue, validNumberValue } from './utils/valueUtil';
 import { getDOM } from 'rc-util/lib/Dom/findDOMNode';
 
 export const DEFAULT_PREFIX = 'rc-table';
@@ -331,12 +331,8 @@ function Table<RecordType extends DefaultRecordType>(
         if (scrollBodyRef.current instanceof HTMLElement) {
           // Native scroll
           const { index, top, key } = config;
-
-          // * 考虑top为0的情况
-          if (top || top === 0) {
-            scrollBodyRef.current?.scrollTo({
-              top,
-            });
+          if (validNumberValue(top)) {
+            scrollBodyRef.current?.scrollTo({ top });
           } else {
             const mergedKey = key ?? getRowKey(mergedData[index]);
             scrollBodyRef.current.querySelector(`[data-row-key="${mergedKey}"]`)?.scrollIntoView();

diff --git a/src/utils/valueUtil.tsx b/src/utils/valueUtil.tsx
@@ -36,3 +36,7 @@ export function getColumnsKey<T = any>(columns: readonly GetColumnKeyColumn<T>[]
 export function validateValue<T>(val: T) {
   return val !== null && val !== undefined;
 }
+
+export function validNumberValue(value: any) {
+  return typeof value === 'number' && !Number.isNaN(value);
+}