Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change tag td => th #1075

Merged
merged 4 commits into from
Feb 4, 2024
Merged

fix: change tag td => th #1075

merged 4 commits into from
Feb 4, 2024

Conversation

li-jia-nan
Copy link
Member

Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2024 10:11am

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4b67382) 99.51% compared to head (bdfb8bf) 50.21%.
Report is 3 commits behind head on master.

Files Patch % Lines
docs/examples/fixedColumns.tsx 0.00% 2 Missing ⚠️
src/hooks/useColumns/index.tsx 94.44% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1075       +/-   ##
===========================================
- Coverage   99.51%   50.21%   -49.31%     
===========================================
  Files          47       97       +50     
  Lines        4569     9065     +4496     
  Branches      579      631       +52     
===========================================
+ Hits         4547     4552        +5     
- Misses         22     4463     +4441     
- Partials        0       50       +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/Header/Header.tsx Outdated Show resolved Hide resolved
src/Header/Header.tsx Outdated Show resolved Hide resolved
src/Header/Header.tsx Outdated Show resolved Hide resolved
src/Header/HeaderRow.tsx Outdated Show resolved Hide resolved
tests/Table.spec.jsx Outdated Show resolved Hide resolved
tests/Table.spec.jsx Outdated Show resolved Hide resolved
@zombieJ zombieJ merged commit 356eb90 into master Feb 4, 2024
9 of 11 checks passed
@zombieJ zombieJ deleted the fix-td branch February 4, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

没有设置 title 的列,展示时表头变成了 td,应该是 th
2 participants