fix:doesn't scroll when use scrollTo with top zero
#1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
afc163
reviewed
Aug 23, 2024
|
补一个测试用例。 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1180 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 75 75
Lines 7402 7416 +14
Branches 1109 1110 +1
=======================================
+ Hits 7232 7246 +14
Misses 164 164
Partials 6 6 ☔ View full report in Codecov by Sentry. |
added 2 commits
August 23, 2024 18:29
…into fix/scrollbehavior
li-jia-nan
reviewed
Aug 24, 2024
| @@ -332,7 +332,8 @@ function Table<RecordType extends DefaultRecordType>( | |||
| // Native scroll | |||
| const { index, top, key } = config; | |||
|
|
|||
| if (top) { | |||
| // * 考虑top为0的情况 | |||
| if (top || top === 0) { | |||
There was a problem hiding this comment.
逻辑不太清晰，不能依靠注释来解释逻辑，我的建议是写一个方法判断：
function isVerifyValue(value: any) {
return typeof value === "number" && !Number.isNaN(value);
}
if (isValidValue(top)) {
scrollBodyRef.current?.scrollTo({ top });
}There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ant-design/ant-design#50547