Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expandIconRender): Add expandIconRender prop for overriding expa… #187

Closed
wants to merge 1 commit into from

Conversation

hrgui
Copy link

@hrgui hrgui commented Feb 16, 2018

…ndIcon

Closes #186

will do unit tests once i understand how they are done

@codecov-io
Copy link

Codecov Report

Merging #187 into master will decrease coverage by 0.12%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   96.06%   95.93%   -0.13%     
==========================================
  Files          17       17              
  Lines         712      714       +2     
  Branches      189      190       +1     
==========================================
+ Hits          684      685       +1     
- Misses         26       27       +1     
  Partials        2        2
Impacted Files Coverage Δ
src/ExpandableTable.js 98.11% <ø> (ø) ⬆️
src/ExpandableRow.js 95.23% <66.66%> (-2.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcc0fcb...0e973a1. Read the comment docs.

@yesmeck
Copy link
Member

yesmeck commented Feb 23, 2018

Yes, please add a test case, and I'd prefer expandIcon as the name.

@kagd kagd mentioned this pull request Aug 31, 2018
@yesmeck
Copy link
Member

yesmeck commented Oct 15, 2018

#236

@yesmeck yesmeck closed this Oct 15, 2018
@hrgui hrgui deleted the feat/expandIconRender branch October 31, 2018 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants