Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

click close do not trigger Trigger #110

Merged
merged 1 commit into from
Apr 28, 2018

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Apr 28, 2018

ref: ant-design/ant-design#10274

Stop propagation when close button click. (rc-select also need this update)

@zombieJ zombieJ requested a review from yesmeck April 28, 2018 01:47
@codecov-io
Copy link

Codecov Report

Merging #110 into master will decrease coverage by 0.39%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #110     +/-   ##
=========================================
- Coverage   85.57%   85.18%   -0.4%     
=========================================
  Files           7        7             
  Lines         617      621      +4     
  Branches      194      195      +1     
=========================================
+ Hits          528      529      +1     
- Misses         86       89      +3     
  Partials        3        3
Impacted Files Coverage Δ
src/Select.jsx 81.17% <100%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ce1332...1d897e9. Read the comment docs.

@yesmeck
Copy link
Member

yesmeck commented Apr 28, 2018

我一直以为设计就是这样的 😳

@zombieJ zombieJ merged commit d9b55e1 into react-component:master Apr 28, 2018
vthinkxie pushed a commit to NG-ZORRO/ng-zorro-antd that referenced this pull request Oct 18, 2018
…emove (#2290)

* fix(module:select,tree-select): prevent pop the dropdown when click remove

ref:
- ant-design/ant-design#10274
- react-component/select#296
- react-component/tree-select#110

close #2276

* test(module:tree-select): fix test
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…emove (NG-ZORRO#2290)

* fix(module:select,tree-select): prevent pop the dropdown when click remove

ref:
- ant-design/ant-design#10274
- react-component/select#296
- react-component/tree-select#110

close NG-ZORRO#2276

* test(module:tree-select): fix test
Saint-Prince added a commit to Saint-Prince/ng-zorro-antd that referenced this pull request Sep 10, 2021
…emove (#2290)

* fix(module:select,tree-select): prevent pop the dropdown when click remove

ref:
- ant-design/ant-design#10274
- react-component/select#296
- react-component/tree-select#110

close #2276

* test(module:tree-select): fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants