Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not expand tree after clear the input #132

Closed
wants to merge 2 commits into from

Conversation

exonuclease
Copy link

@exonuclease exonuclease commented Nov 22, 2018

I find that all nodes are expanded when starting the search.And In some cases
this component will request the api for many times.

  1. Load data asynchronously.
  2. Search the nodes.
  3. Some nodes match the search string.
  4. Press backspace to delete all search text.
    If some one need help to reproduce the problem please contact with me.

@codecov-io
Copy link

Codecov Report

Merging #132 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #132   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         226    226           
  Branches       44     44           
=====================================
  Hits          226    226

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff066fc...d720c6c. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Nov 22, 2018

This may not fix all related loadData issue. We should make the TreeSelect not call loadData when searching and set expandedKeys back instead of just reset to [] when search input clear:

kapture 2018-11-23 at 0 05 13

@exonuclease
Copy link
Author

Yes I think your idea is better.I just provide a temporary solution.

@zombieJ
Copy link
Member

zombieJ commented Nov 23, 2018

Yes I think your idea is better.I just provide a temporary solution.

👌, Let me handle this : )

@zombieJ zombieJ closed this Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants