Fix for 'cannot access clientX on undefined' exception. #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reproduce, access a DraggableCore element using touch emulation in Chrome. The exception will be thrown on drag stop. This will leave the element active, so if you drag another element, both elements end up being dragged together. I'm not sure if this is the correct fix, I may be treating symptoms rather than root cause, but it appears to work.
|
This may be related to #118 - looking into it. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce, access a DraggableCore element using touch emulation in Chrome. The exception will be thrown on drag stop.
This will leave the element active, so if you drag another element, both elements end up being dragged together.
I'm not sure if this is the correct fix, I may be treating symptoms rather than root cause, but it appears to work.