-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vest sync validation #117
Vest sync validation #117
Conversation
jorisre
commented
Jan 22, 2021
- Update to V3
- Add sync validation
Size Change: +199 B (+1%) Total Size: 15.2 kB
ℹ️ View Unchanged
|
const errors = result.getErrors(); | ||
|
||
if (!result.hasErrors()) { | ||
return { values: values as any, errors: {} }; | ||
return { values, errors: {} }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏 thanks for fixing the type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
🎉 This PR is included in version 2.0.0-beta.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* feat: V2 init BREAKING CHANGE: there will be some breaking changes in the next versions * feat: improve modules support * fix: yup resolver typescript errors * Fix: vest validate all criteria + better TypeSript support + add tests * test: add components test to ensure TypeScript is working as expected Related to #97 * chore: improve zod resolvers types * chore(eslint): remove warnings * test: add severals tests & improve typings * chore: setup compressed-size * test: update describe * feat: add Zod sync validation (#114) * feat: add Joi sync validation (#116) * feat: add Joi sync validation * fix(joi): sync error * test: add validateAllCriteria test * test(joi): update test description * feat: add Yup sync validation (#115) * feat: add Yup sync validation * test(zod): add tests * test(zod): update tests * test(yup): add validateAllCriteria test * feat: add Vest sync validation + update to v3 (#117) * feat: update to react-hook-form v7 BREAKING CHANGE: Require react-hook-form >= 7 * chore: fix typescript error (#123) * chore: update deps * chore: fix TypeScript error * refactor: replace deprecated transformToNestObject (#125) * fix: pass down Joi context (#124) * fix: zod union error + reduce size (#126) * test: extract fixtures * fix: zod resolver union error + reduce resolver size * feat: add error's ref (#127) * feat: add error's ref * test: add error's ref + extract fixtures * test: add nested test * refactor: rename toNestObject to toNestError * Reduce superstruct resolver size (#128) * test: extract test's fixtures * test: jest fixtures config * perf: reduce superstruct resolver size * feat: add error's ref * test: add error's ref + extract fixtures * test: add nested test * refactor: rename toNestObject to toNestError * refactor: remove duplicate line * chore: update superstruct peer dep * perf: reduce vest resolver size (#129) * test: extract test's fixtures * test: jest fixtures config * perf: reduce superstruct resolver size * feat: add error's ref * test: add error's ref + extract fixtures * test: add nested test * refactor: rename toNestObject to toNestError * refactor: remove duplicate line * perf: recude vest resolver bundle size * perf: reduce joi resolver's size (#131) * perf: reduce Joi resolver's size * perf: reduce Vest resolver's size * perf: reduce yup resolver's size (#130) * refactor: remove convertArrayToPathName (#132) * perf: reduce joi and yup bundle size (#134) * fix(types): add Lazy schema support to resolver * docs: v2 doc (#136)