Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zod fix union error + reduce resolver size #126

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Conversation

jorisre
Copy link
Member

@jorisre jorisre commented Feb 2, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2021

Size Change: -539 B (-3%)

Total Size: 15.8 kB

Filename Size Change
zod/dist/zod.js 467 B -146 B (-24%) 🎉
zod/dist/zod.modern.js 406 B -103 B (-20%) 🎉
zod/dist/zod.module.js 482 B -144 B (-23%) 🎉
zod/dist/zod.umd.js 571 B -146 B (-20%) 🎉
ℹ️ View Unchanged
Filename Size Change
dist/resolvers.js 240 B 0 B
dist/resolvers.modern.js 247 B 0 B
dist/resolvers.module.js 251 B 0 B
dist/resolvers.umd.js 331 B 0 B
joi/dist/joi.js 682 B 0 B
joi/dist/joi.modern.js 564 B 0 B
joi/dist/joi.module.js 698 B 0 B
joi/dist/joi.umd.js 783 B 0 B
superstruct/dist/superstruct.js 1.05 kB 0 B
superstruct/dist/superstruct.modern.js 1 kB 0 B
superstruct/dist/superstruct.module.js 1.08 kB 0 B
superstruct/dist/superstruct.umd.js 1.15 kB 0 B
vest/dist/vest.js 703 B 0 B
vest/dist/vest.modern.js 649 B 0 B
vest/dist/vest.module.js 713 B 0 B
vest/dist/vest.umd.js 785 B 0 B
yup/dist/yup.js 746 B 0 B
yup/dist/yup.modern.js 640 B 0 B
yup/dist/yup.module.js 755 B 0 B
yup/dist/yup.umd.js 837 B 0 B

compressed-size-action

@bluebill1049
Copy link
Member

oh wow!!!

return {};
}
const errors: Record<string, FieldError> = {};
for (; zodErrors.length; ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't know you can do this!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saving bytes 😬 More coming ;)

Copy link
Member

@bluebill1049 bluebill1049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@jorisre jorisre merged commit 19dfa9b into beta Feb 3, 2021
@jorisre jorisre deleted the zod-fix-union-error branch February 3, 2021 08:20
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2021

🎉 This PR is included in version 2.0.0-beta.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jorisre jorisre mentioned this pull request Feb 3, 2021
5 tasks
jorisre added a commit that referenced this pull request Apr 2, 2021
* feat: V2 init

BREAKING CHANGE: there will be some breaking changes in the next versions

* feat: improve modules support

* fix: yup resolver typescript errors

* Fix: vest validate all criteria + better TypeSript support + add tests

* test: add components test to ensure TypeScript is working as expected

Related to #97

* chore: improve zod resolvers types

* chore(eslint): remove warnings

* test: add severals tests & improve typings

* chore: setup compressed-size

* test: update describe

* feat: add Zod sync validation (#114)

* feat: add Joi sync validation (#116)

* feat: add Joi sync validation

* fix(joi): sync error

* test: add validateAllCriteria test

* test(joi): update test description

* feat: add Yup sync validation (#115)

* feat: add Yup sync validation

* test(zod): add tests

* test(zod): update tests

* test(yup): add validateAllCriteria test

* feat: add Vest sync validation + update to v3 (#117)

* feat: update to react-hook-form v7

BREAKING CHANGE: Require react-hook-form >= 7

* chore: fix typescript error (#123)

* chore: update deps

* chore: fix TypeScript error

* refactor: replace deprecated transformToNestObject (#125)

* fix: pass down Joi context (#124)

* fix: zod union error + reduce size (#126)

* test: extract fixtures

* fix: zod resolver union error + reduce resolver size

* feat: add error's ref (#127)

* feat: add error's ref

* test: add error's ref + extract fixtures

* test: add nested test

* refactor: rename toNestObject to toNestError

* Reduce superstruct resolver size (#128)

* test: extract test's fixtures

* test: jest fixtures config

* perf: reduce superstruct resolver size

* feat: add error's ref

* test: add error's ref + extract fixtures

* test: add nested test

* refactor: rename toNestObject to toNestError

* refactor: remove duplicate line

* chore: update superstruct peer dep

* perf: reduce vest resolver size (#129)

* test: extract test's fixtures

* test: jest fixtures config

* perf: reduce superstruct resolver size

* feat: add error's ref

* test: add error's ref + extract fixtures

* test: add nested test

* refactor: rename toNestObject to toNestError

* refactor: remove duplicate line

* perf: recude vest resolver bundle size

* perf: reduce joi resolver's size (#131)

* perf: reduce Joi resolver's size

* perf: reduce Vest resolver's size

* perf: reduce yup resolver's size (#130)

* refactor: remove convertArrayToPathName (#132)

* perf: reduce joi and yup bundle size (#134)

* fix(types): add Lazy schema support to resolver

* docs: v2 doc (#136)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants