Skip to content
This repository has been archived by the owner on Jun 16, 2023. It is now read-only.

Swift Rewrite #5

Open
MarcoScabbiolo opened this issue Feb 3, 2021 · 4 comments
Open

Swift Rewrite #5

MarcoScabbiolo opened this issue Feb 3, 2021 · 4 comments
Assignees

Comments

@MarcoScabbiolo
Copy link

MarcoScabbiolo commented Feb 3, 2021

Rewrite the native code for core and barcode in Swift.
Exclude any unused code (face detection, etc.), clean up the surface API for ease of usage and review portability with the Android API.

Swiftify can help a lot

@MarcoScabbiolo MarcoScabbiolo self-assigned this Feb 8, 2021
@MarcoScabbiolo MarcoScabbiolo changed the title iOS Rewrite Swift Rewrite Feb 8, 2021
MarcoScabbiolo pushed a commit that referenced this issue Feb 9, 2021
MarcoScabbiolo pushed a commit that referenced this issue Feb 9, 2021
MarcoScabbiolo pushed a commit that referenced this issue Feb 9, 2021
MarcoScabbiolo pushed a commit that referenced this issue Feb 10, 2021
MarcoScabbiolo pushed a commit that referenced this issue Feb 17, 2021
MarcoScabbiolo pushed a commit that referenced this issue Feb 20, 2021
MarcoScabbiolo pushed a commit that referenced this issue Feb 22, 2021
MarcoScabbiolo pushed a commit that referenced this issue Feb 24, 2021
MarcoScabbiolo pushed a commit that referenced this issue Feb 25, 2021
MarcoScabbiolo pushed a commit that referenced this issue Feb 26, 2021
MarcoScabbiolo pushed a commit that referenced this issue Mar 1, 2021
@cristianoccazinsp
Copy link

cristianoccazinsp commented Mar 2, 2021

@MarcoScabbiolo while you are at it, you may want to consider also removing some of the deprecated API calls. More specifically, captureStillImageAsynchronouslyFromConnection is deprecated, and so most of the classes related to it (https://developer.apple.com/documentation/avfoundation/avcapturestillimageoutput?language=objc).

Not swift, but here's an example of the code migration for the new API: https://stackoverflow.com/questions/39872528/ios-10-objective-c-how-to-implement-avcapturephotooutput-to-capture-image

MarcoScabbiolo pushed a commit that referenced this issue Mar 2, 2021
@raimonkh
Copy link

Is there a plan to remove writeImageDataToSavedPhotosAlbum ? from the deprecated ALAssetsLibrary? Can we help?
v4 was released with what seems Android rewrite, but not iOS rewrite, am I right?

@MarcoScabbiolo
Copy link
Author

MarcoScabbiolo commented Oct 4, 2021

@raimonkh Please see: react-native-camera/react-native-camera#3000 (comment) . If anyone wants to keep going with the v4, its all yours, but know that our vision for it is already achieved in react-native-vision-camera

@raimonkh
Copy link

raimonkh commented Oct 4, 2021

Thanks @MarcoScabbiolo 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants