Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setKeyboardShown in willshow and willhide #287

Closed
wants to merge 1 commit into from
Closed

setKeyboardShown in willshow and willhide #287

wants to merge 1 commit into from

Conversation

phuocantd
Copy link

Summary

resolve issue: #286

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅
Android ✅
Web ❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I've created a snack to demonstrate the changes: LINK HERE

@LinusU
Copy link
Member

LinusU commented Nov 29, 2021

This seems like quite a breaking change, and I don't think that this is what everyone wants (not that everyone wants what we currently have though 😅)

I think that the approach taken in #140 or potentially #168 is a better approach. What do you think about those?

@phuocantd
Copy link
Author

@LinusU What do you think when adding a state willShown like shown state to know when keyboardWillShow and keyboardWillHide

@phuocantd phuocantd closed this Aug 20, 2022
@phuocantd phuocantd deleted the phuocantd/keyboardshown branch August 20, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phuocantd @LinusU