refactor: improve useKeyboard cross-platform compatibility #401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request enhances the
useKeyboard
hook in thereact-native-community/hooks
library to improve cross-platform compatibility for keyboard events. Currently, the hook supports bothkeyboardWillShow
andkeyboardWillHide
events on iOS, but for Android, it useskeyboardDidShow
andkeyboardDidHide
events. To ensure consistent behavior across platforms, this update introduces conditional event listeners based on the platform.The motivation behind this change is to provide a consistent and reliable experience for handling keyboard events in a cross-platform React Native application. By utilizing the appropriate keyboard events based on the platform, this enhancement aims to improve the overall user experience and streamline the development process.
Test Plan
What's required for testing (prerequisites)?
react-native-community/hooks
library is installed.What are the steps to reproduce (after prerequisites)?
useKeyboard
hook in a React Native component.keyboardShown
,coordinates
, andkeyboardHeight
values when the keyboard is shown and hidden.Compatibility
Checklist
README.md