Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add back locale prop #544

Merged
merged 4 commits into from
Dec 20, 2021
Merged

feat: add back locale prop #544

merged 4 commits into from
Dec 20, 2021

Conversation

vonovak
Copy link
Member

@vonovak vonovak commented Dec 20, 2021 •
edited
Loading

Summary

closes #542

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

tested locally with spinner mode and locale cs-CZ

Compatibility

OS Implemented
iOS ✅
Android ❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)
  • I have added automated tests, either in JS or e2e tests, as applicable

@vonovak vonovak marked this pull request as ready for review December 20, 2021 22:26
@vonovak vonovak enabled auto-merge (squash) December 20, 2021 22:39
@vonovak vonovak merged commit 05f39fa into master Dec 20, 2021
@vonovak vonovak deleted the feat/add-back-locale branch December 20, 2021 22:40
vonovak pushed a commit that referenced this pull request Dec 21, 2021
@semantic-release-bot
chore(release): 5.1.0 [skip ci]
fc0c064 
# [5.1.0](v5.0.2...v5.1.0) (2021-12-21)

### Features

* add back locale prop ([#544](#544)) ([05f39fa](05f39fa)), closes [#540](#540)
@vonovak
Copy link
Member Author

vonovak commented Dec 21, 2021

🎉 This issue has been resolved in version 5.1.0 🎉

If this package helps you, consider sponsoring us! 🚀

@vonovak vonovak mentioned this pull request Mar 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inability to display 24hr time in Time Picker on iOS due to locale prop removed in v. 5.0.0
1 participant
@vonovak