Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Break in Windows JS following #574 #605

Merged
merged 5 commits into from
Apr 29, 2022
Merged

Fix Break in Windows JS following #574 #605

merged 5 commits into from
Apr 29, 2022

Conversation

chiaramooney
Copy link
Contributor

Summary

Changes in #574 break Windows JS because no picker.windows.js file exists.

Test Plan

Tested via React Native Windows app React Native Gallery.

Compatibility

| Windows | ✅ |

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)
  • I have added automated tests, either in JS or e2e tests, as applicable

@vonovak vonovak merged commit 24f3452 into react-native-datetimepicker:master Apr 29, 2022
vonovak pushed a commit that referenced this pull request Apr 29, 2022
@semantic-release-bot
chore(release): 6.1.3 [skip ci]
e3c05a8 
## [6.1.3](v6.1.2...v6.1.3) (2022-04-29)

### Bug Fixes

* Break in Windows JS following [#574](#574) ([#605](#605)) ([24f3452](24f3452))
@vonovak
Copy link
Member

vonovak commented Apr 29, 2022

🎉 This issue has been resolved in version 6.1.3 🎉

If this package helps you, consider sponsoring us! 🚀

@acaininet acaininet mentioned this pull request May 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vonoro vonoro vonoro approved these changes

@vonovak vonovak vonovak approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chiaramooney @vonovak @vonoro