Add missing pbxproj for autolinking #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonovak
pushed a commit
that referenced
this pull request
Sep 18, 2022
## [6.3.4](v6.3.3...v6.3.4) (2022-09-18) ### Bug Fixes * add missing pbxproj for autolinking ([#659](#659)) ([f4efa58](f4efa58))
|
🎉 This issue has been resolved in version 6.3.4 🎉 If this package helps you, consider sponsoring us! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up to: #658
Unfortunately, while the local example app works, it's because it's linked in a different way than the final package.
The contents of the
pbxprojcan be empty since RN CLI only uses its existence to assess whether it should autolink iOS code.Really sorry for this mistake 🙇
Test Plan
You can download the latest iOS version and see that in the
Podfile.lock,RNDateTimePickermodule is missing. Applying the changes from this PR fixes it.What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdexample/App.js)