Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to Yarn 4, remove segmented-control patch #885

Merged
merged 6 commits into from
Apr 18, 2024

Conversation

Saadnajmi
Copy link
Contributor

@Saadnajmi Saadnajmi commented Apr 17, 2024

Summary

Another split from #879 , this PR updates the repo to Yarn 4. It also removes the patch to segmented-control now that react-native-segmented-control/segmented-control#848 merged

Test Plan

CI should pass

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)
  • I have added automated tests, either in JS or e2e tests, as applicable

@Saadnajmi Saadnajmi changed the title chore: Update to Yarn 4 chore: Update to Yarn 4, remove segmented-control patch Apr 18, 2024
@Saadnajmi
Copy link
Contributor Author

@vonovak Could we also take this to reduce the footprint of #879 ?

@vonovak vonovak merged commit d75913f into react-native-datetimepicker:master Apr 18, 2024
5 checks passed
@vonovak
Copy link
Member

vonovak commented Apr 18, 2024

Thank you for your PR! 🚀🚀🚀

@Saadnajmi Saadnajmi deleted the yarn4 branch April 18, 2024 19:35
@vonovak
Copy link
Member

vonovak commented Apr 25, 2024

🎉 This issue has been resolved in version 8.0.0 🎉

If this package helps you, consider sponsoring us! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants