fix(android): Re-enable setting max date #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, and thank you for the PR! |
vonovak
pushed a commit
that referenced
this pull request
Jun 17, 2024
## [8.1.1](v8.1.0...v8.1.1) (2024-06-17) ### Bug Fixes * **android:** re-enable setting max date ([#908](#908)) ([1d966e6](1d966e6))
|
🎉 This issue has been resolved in version 8.1.1 🎉 If this package helps you, consider sponsoring us! 🚀 |
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a regression in 8.1.0 caused by the removal of a condition that sets the max date in Android:
3b63563#diff-c69fee0670676f78b9b27aeb6fbadc9c9edf486510166dc8194c5c8232f626ecL119-L121
Test Plan
What's required for testing (prerequisites)?
Run the example app using the command:
yarn start:androidWhat are the steps to reproduce (after prerequisites)?
Tap
TOGGLEMINMAXDATEbutton to open the DatePicker dialog. One should only be able to tap the available dates.Compatibility
Checklist
I added the documentation inREADME.mdI updated the typed files (TS and Flow)I added a sample use of the API in the example project (example/App.js)I have added automated tests, either in JS or e2e tests, as applicable