Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion handler is not called #311

Merged
merged 7 commits into from
Oct 9, 2022
Merged

Completion handler is not called #311

merged 7 commits into from
Oct 9, 2022

Conversation

apfritts
Copy link
Contributor

@apfritts apfritts commented Jul 24, 2021

The provided completionHandler is being saved to the remoteNotificationCallbacks dictionary, but the native onFinishRemoteNotification:(NSString *)notificationId fetchResult:(UIBackgroundFetchResult)result function didn't actually lookup and call the completion handler.

I believe this fixes that bug and addresses #216 #244 #297 as well.

@leethree
Copy link

Looks great. I think the example project needs to be updated as well 👍🏼

@apfritts
Copy link
Contributor Author

@leethree I updated the example project and rebased my PR. I still need to re-confirm that this is functioning properly before it gets merged since there seem to have been quite a few other commits since I opened this.

@christophercarney
Copy link

This is still an issue -- any updates on when this can get reviewed and merged?

Copy link
Collaborator

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Naturalclar Naturalclar merged commit dd46810 into react-native-push-notification:master Oct 9, 2022
@chrisbobbe
Copy link

This merged work looks like an approximate revert of 1506ddf / #241, which was marked as addressing #163. Do we expect #163 not to be re-introduced?

@floydkim
Copy link

@chrisbobbe @Naturalclar
I'm experiencing this issue #163 after bumping to 1.11.0. (previously 1.10.1)
I think, in my project, there's some duplicated handling of FCM event.
(I'm using a couple of libraries that deal with FCM events.)

I think we need to be clear about the responsibilities of this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants