Set useNativeDriver explicitly for Animations #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-E-Adams
requested review from
jgcmarins,
MateusAndrade and
mikehardy
as code owners
|
I have a feeling the CI step failed because of flakiness, but can't rerun it myself. |
jgcmarins
reviewed
Nov 15, 2019
There was a problem hiding this comment.
interesting, it says that it's false by default
should we let user land handle this?
|
Yeah it is. I remember reading that eventually it will be true by default somewhere in the code. We could make it a user decision with false by default - I wouldn't want it true by default because it can occasionally cause problems. |
jgcmarins
approved these changes
Nov 15, 2019
cuonghuynhpycogroup
pushed a commit
to cuonghuynhpycogroup/react-native-share
that referenced
this pull request
Dec 25, 2019
* master-base: (215 commits) Update react-native to 0.61.4 (react-native-share#637) Update and fix Gradle setup (react-native-share#588) set useNativeDriver explicitly for Animations (react-native-share#633) correctly type image source (react-native-share#632) ci(fix): adapt to new workflow (react-native-share#626) fix: added missing "v" to `source` field in podspec (react-native-share#619) chore(readme): mocking with Jest example (react-native-share#610) iOS 13: Resolve promise if ShareSheet is manually dismissed (react-native-share#607) Update README.md fix: remove uncessary tools replace on build gradle chore(lint): fixing lint errors Makes sharing with Snapchat work on Android (react-native-share#464) Fixed validate error Removed react-native Share dependency Only call successCallback when completed is true Change readme.md Update Gradle wrapper to 5.6.2 build(deps): bump eslint-utils from 1.4.0 to 1.4.2 (react-native-share#580) Send email to predefined email address - Example Send email to predefined email address ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Just noticed another flow issue when running flow in our codebase. Eventually useNativeDriver is a non-optional field facebook/react-native@d123bea
so may as well fix this up now.
Test Plan
Run flow!