-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix permission checking in the Quit state #576
Conversation
…vailable when the app is in the state Quit
@c960657, @LinusU, @danjenkins, @saghul, @manuquentin please review. |
@c960657, @LinusU, @danjenkins, @saghul please review. |
Sorry, I don't have enough experience with this package to review this PR.. |
I can confirm this fixed issue #577 for me. Tested on
|
Can also confirm this fixed the problem for me
|
Thank you so much Problem Solved: |
please confirm this pr @manuquentin |
yes it's work |
@fukemy could you please provide code inside the backgroundMessageHandler, I am having issues displaying the call when the app was killed on Android |
Ok wait me few hours, im busy now |
@fukemy 🙏 |
Read commit difference them modify source code inside your project |
can you provide the code you wrote to achieve what you were trying to do in your problem:
|
Problem:
I'm trying to
displayIncomingCall
in theBackgroundMessaging
(by Firebase) when the app in the Quit state (when a user has killed the application), but it doesn't work becausehasPermissions
always returns false.hasPermissions
returns false becauseActivity
is always null in the Quit state.Solution:
Use
ReactApplicationContext
to check permissions.