Merge pull request #30 from reactioncommerce/fix-28-mohan-multishop-d…

…up-tag-create

fix: allow different shops to have same tag name

index.js

@@ -1,3 +1,5 @@
 import register from "./src/index.js";
 
+export { default as migrations } from "./migrations/index.js";
+
 export default register;

migrations/2.js

@@ -0,0 +1,20 @@
+/**
+ * @summary remove index slug_1 from tags
+ * @param {Object} args - the arguments
+ * @param {Object} args.db - the DB client
+ * @param {Function} args.progress - a function to set the progress of the operation
+ * @returns {undefined}
+ */
+async function up({ db, progress }) {
+  progress(0);
+
+  const index = "slug_1";
+  await db.collection("Tags").dropIndex(index);
+
+  progress(100);
+}
+
+export default {
+  down: "unnecessary",
+  up
+};

migrations/index.js

@@ -0,0 +1,13 @@
+import { migrationsNamespace } from "./migrationsNamespace.js";
+import migration2 from "./2.js";
+
+export default {
+  tracks: [
+    {
+      namespace: migrationsNamespace,
+      migrations: {
+        2: migration2
+      }
+    }
+  ]
+};

migrations/migrationsNamespace.js

@@ -0,0 +1 @@
+export const migrationsNamespace = "tags";

package.json

@@ -27,6 +27,7 @@
   "dependencies": {
     "@reactioncommerce/api-utils": "^1.16.5",
     "@reactioncommerce/data-factory": "~1.0.1",
+    "@reactioncommerce/db-version-check": "^1.0.0",
     "@reactioncommerce/file-collections": "~0.9.3",
     "@reactioncommerce/random": "~1.0.2",
     "@reactioncommerce/reaction-error": "~1.0.1",

src/index.js

@@ -6,6 +6,7 @@ import queries from "./queries/index.js";
 import resolvers from "./resolvers/index.js";
 import schemas from "./schemas/index.js";
 import { Tag } from "./simpleSchemas.js";
+import preStartup from "./preStartup.js";
 
 /**
  * @summary Import and call this function to add this plugin to your API.
@@ -18,6 +19,9 @@ export default async function register(app) {
     name: "tags",
     version: pkg.version,
     i18n,
+    functionsByType: {
+      preStartup: [preStartup]
+    },
     collections: {
       Tags: {
         name: "Tags",
@@ -27,7 +31,7 @@ export default async function register(app) {
           [{ name: 1 }, { name: "c2_name" }],
           [{ relatedTagIds: 1 }, { name: "c2_relatedTagIds" }],
           [{ shopId: 1 }, { name: "c2_shopId" }],
-          [{ slug: 1 }, { unique: true }]
+          [{ slug: 1, shopId: 1 }, { unique: true }]
         ]
       }
     },

src/preStartup.js

@@ -0,0 +1,32 @@
+import doesDatabaseVersionMatch from "@reactioncommerce/db-version-check";
+import { migrationsNamespace } from "../migrations/migrationsNamespace.js";
+
+const expectedVersion = 2;
+
+/**
+ * @summary Called before startup
+ * @param {Object} context Startup context
+ * @returns {undefined}
+ */
+export default async function preStartup(context) {
+  const setToExpectedIfMissing = async () => {
+    const anyAccount = await context.collections.Accounts.findOne();
+    const anyGroup = await context.collections.Groups.findOne();
+    return !anyAccount && !anyGroup;
+  };
+
+  const ok = await doesDatabaseVersionMatch({
+    // `db` is a Db instance from the `mongodb` NPM package,
+    // such as what is returned when you do `client.db()`
+    db: context.app.db,
+    // These must match one of the namespaces and versions
+    // your package exports in the `migrations` named export
+    expectedVersion,
+    namespace: migrationsNamespace,
+    setToExpectedIfMissing
+  });
+
+  if (!ok) {
+    throw new Error(`Database needs migrating. The "${migrationsNamespace}" namespace must be at version ${expectedVersion}. See docs for more information on migrations: https://github.com/reactioncommerce/api-migrations`);
+  }
+}