Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infinite loader if the payment is rejected #699

Closed
CristianCucunuba opened this issue Jul 10, 2020 · 3 comments · Fixed by #700
Closed

infinite loader if the payment is rejected #699

CristianCucunuba opened this issue Jul 10, 2020 · 3 comments · Fixed by #700
Assignees

Comments

@CristianCucunuba
Copy link

Type: minor

Describe the bug
When you are placing and order on the checkout, using X payment gateway, If the payment is reject or fails the loader waiting for the order to place, never stops and we can't notifying the user that the payment failed.

To Reproduce
Steps to reproduce the behavior:

  1. Add a product to the cart
  2. Go to the checkout and fill step 1 and 2
  3. Select your payment method and make sure it fails, for example entering a wrong credit card number if you use stripe
  4. Place the order
  5. See the infinite loader

Expected behavior
Stop the loader and display the alert with the error. CheckoutActions already do that but this conditional is not letting the component set the alert. For some reason the component is already unmounted and the component can't update the state

Screenshots
image

@janus-reith janus-reith self-assigned this Jul 10, 2020
@janus-reith
Copy link
Collaborator

@CristianCucunuba Thanks for filing the issue!
Could you add which branch/version you use while observing that issue?

It seems like you spotted the right place, as due to my latest changes, this._isMounted is not set to true in the first place:
0ae583e#diff-9b6019bce1be1df5431a56f4a139663dL77
Fixing this right away.

However, as this should not be present in the latest v3.1.0 stable release, I'd like to clarify if you might have encountered some other issue, where the component might actually not be mounted.

@CristianCucunuba
Copy link
Author

I'm using v3.1.0/trunk, at the moment I haven't seen other issue with the component

@janus-reith
Copy link
Collaborator

janus-reith commented Jul 14, 2020

Closing this now that #700 is merged and @manueldelreal confirmed that showing an error message works.
(Further context: Usually I would leave this open until the fix landed in a release, but this error should only occur in trunk but not the latest stable v3.1.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants