Set _isMounted to true after component mounted #700
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Janus Reith [email protected]
Resolves #699
Impact: minor
Type: bugfix
Issue
In 0ae583e#diff-9b6019bce1be1df5431a56f4a139663dL77 I removed the whole
componentDidMount
part, not realizing thatthis._isMounted = true;
was unrelated to the tracking events underneath.Solution
Add back a
componentDidMount
lifecycle function to set_isMounted
to true in the first place.Don't close #699 until confirmed that there is no separate issue present on older versions, where the component might actually not be mounted properly.
Testing
See #699