Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add graphql subscription support #492

Merged
merged 4 commits into from
Jan 29, 2019

Conversation

mikemurray
Copy link
Member

Resolves reactioncommerce/reaction#4938
Impact: minor
Type: feature

Issue

Add support for graphql subscriptions

Solution

Update packages and split the httpLink to accept subscriptions.

Breaking changes

none

Testing

Follow testing instructions here: reactioncommerce/reaction#4938

@kieckhafer kieckhafer changed the title [WIP] feat: add graphql subscription upport feat: add graphql subscription support Jan 28, 2019
@kieckhafer
Copy link
Member

kieckhafer commented Jan 28, 2019

@impactmass Follow the instructions here: reactioncommerce/reaction#4938

All you'll need to do is add the SubscriptionsTest component anywhere on one of the pages, and see that the count appears.

The matching PR in https://github.com/reactioncommerce/reaction has already been pulled into the develop branch

Copy link
Contributor

@impactmass impactmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works based on testing with <SubscriptionTest /> in reactioncommerce/reaction#4938

@impactmass impactmass merged commit f5efbf8 into develop Jan 29, 2019
@impactmass impactmass deleted the feat-graphql-subscriptions branch January 29, 2019 11:56
@jeffcorpuz jeffcorpuz mentioned this pull request Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants