chore: updated config for modules and tree shaking #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
willopez
approved these changes
Feb 8, 2019
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
aldeed
force-pushed
the
feat-aldeed-support-mjs
branch
from
cbbacdd
to
e6a8c2b
Compare
Changes should not have any effect other than removing warnings from the browser console Signed-off-by: Eric Dobbertin <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: chore
Changes
sideEffects: falseto tell Webpack it's OK to tree shake. If this causes any problems, we can identify which files do have side effects and either remove the side effects or update this config to be a list of those files. See https://webpack.js.org/guides/tree-shaking/Breaking changes
None
Testing
Test with reactioncommerce/reaction-component-library#395. After that PR is published to NPM, we can update the components dependency version in this PR, too, for a more realistic test.