Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tlp): add Featured as the default sort on tag listing page #498

Closed
wants to merge 5 commits into from
Closed

feat(tlp): add Featured as the default sort on tag listing page #498

wants to merge 5 commits into from

Conversation

machikoyasuda
Copy link
Contributor

@machikoyasuda machikoyasuda commented Feb 11, 2019 •
edited
Loading

closes #500

  • add featured-desc as an option in the tag listing page dropdown.
  • add featured-desc as the default option in the tag listing page's catalogItems query, via the UIStore.sortBy variable.
  • add snapshot test

Dependency

Depends on reactioncommerce/reaction#4980 being merged to develop

Testing

@machikoyasuda machikoyasuda added this to the 🏔 Torreys milestone Feb 11, 2019
@machikoyasuda machikoyasuda mentioned this pull request Feb 13, 2019
Merged
@machikoyasuda machikoyasuda changed the title feat(tlp): WIP - add Featured as the default sort on tag listing page feat(tlp): add Featured as the default sort on tag listing page Feb 13, 2019
@machikoyasuda machikoyasuda force-pushed the feat-machikoyasuda-sort-tlp branch 2 times, most recently from efad269 to 7aa555f Compare February 13, 2019 23:38
machikoyasuda
machikoyasuda commented Feb 14, 2019
View reviewed changes
src/pages/tag.js Outdated Show resolved Hide resolved
@machikoyasuda
Copy link
Contributor Author

Closing this PR for now. The fact that the Homepage shares a Dropdown makes the design of this ticket slightly more complex than we have time for. Making an issue to complete this when a more detailed design is created.

@machikoyasuda machikoyasuda mentioned this pull request Mar 14, 2019
Closed
@machikoyasuda machikoyasuda deleted the feat-machikoyasuda-sort-tlp branch June 15, 2019 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemurray mikemurray Awaiting requested review from mikemurray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
🏔 Torreys
Development

Successfully merging this pull request may close these issues.

Tag Listing Page should be ordered by featured by default
2 participants
@machikoyasuda @mikemurray