Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dev utilities to the docker image #504

Merged
merged 1 commit into from
Feb 21, 2019

Conversation

focusaurus
Copy link
Contributor

Impact: minor
Type: feature

Issue

Our docker image was pretty slim. It was hard to debug and troubleshoot issues in there with docker networking, connected services, config files, etc.

Solution

I've added some packages

  • essential development/debugging/troubleshooting tools
    • vim text editor
    • curl http client
  • developer convenience packages
    • less non-medieval pager
    • bash shell with baseline features like tab completion, history

I've also set the shell for the Dockerfile itself to "bash strict mode". It will exit if any command fails, which is usually the correct behavior, and avoids needing to specify set -e in every RUN line and also eliminates the need to use && as a command separator (; is fine with this SHELL setting).

Breaking changes

I don't believe any of these changes are breaking.

Testing

  • Make sure docker-compose up --build works and the app runs correctly

@focusaurus focusaurus added the enhancement For issues that describe a feature that needs to be added, changed, or removed, but is not a bug label Feb 19, 2019
@focusaurus focusaurus added this to the 🏔 Torreys milestone Feb 19, 2019
@focusaurus focusaurus self-assigned this Feb 19, 2019
Copy link
Contributor

@nnnnat nnnnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@focusaurus focusaurus merged commit 9dfcd2d into develop Feb 21, 2019
@focusaurus focusaurus deleted the feat-docker-dev-utils branch February 21, 2019 15:58
@jeffcorpuz jeffcorpuz mentioned this pull request Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For issues that describe a feature that needs to be added, changed, or removed, but is not a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants