chore: ignore snyk js-yaml vuln for 30 days #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Y U NO PASS?!? |
|
Oh dang there are 2 different js-yaml vulns. Yay YAML is so great! |
focusaurus
force-pushed
the
chore-snyk-ignore-js-yaml
branch
2 times, most recently
from
a7738b5
to
28ca1a9
Compare
Signed-off-by: Peter Lyons <[email protected]>
focusaurus
force-pushed
the
chore-snyk-ignore-js-yaml
branch
from
28ca1a9
to
bbd2a89
Compare
|
OK this is good to go now I think @nnnnat . The license compliance check is maybe choking on the fact that I amended my commit and force pushed, but it's not relevant to this change anyway. |
nnnnat
approved these changes
Apr 9, 2019
This was referenced Jul 1, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: chore|security
Issue
We have a snyk vuln deep in our dep tree that is non-trivial to avoid with npm dependency updates at this time.
Solution
Delay 30 days and hope some new deps show up that don't break when we update.
Breaking changes
N/A
Testing
N/A