-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update yarn.lock to resolve snyk js-yaml vuln #531
Conversation
530ab69
to
377d27b
Compare
Also changed everything apollo related to semver ~ ranges. Otherwise new versions cause test failures. (Invariant Violation: Ambiguous GraphQL document: contains 2 operations) Signed-off-by: Peter Lyons <[email protected]>
377d27b
to
48d1668
Compare
OK yay this finally passed circleci. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the thought behind switching from floating minor version (^
) to floating patch (~
) version? Should we update the rest of the package.json file to follow this pattern as well? Is this decision specifically targeted at apollo
related packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't read through the description well enough where the tilde vs caret is explained (thanks Pete). Looks good to me.
@spencern If we leave the carets for apollo stuff, an update breaks the unit tests with
|
@focusaurus |
Invariant Violation: Ambiguous GraphQL document: contains 2 operations