Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(development): fix debugger command in README #539

Merged
merged 1 commit into from
Jun 17, 2019

Conversation

machikoyasuda
Copy link
Contributor

Impact: minor
Type: developer happiness

Issue

The command in the README currently doesn't work.

Solution

Remove babel-node and use node instead, like the current yarn start script does.

Testing

  1. Try docker-compose run --rm --publish 9229:9229 --publish 4000:4000 -e NODE_ENV=development web babel-node --inspect=0.0.0.0:9229 ./src/server.js and confirm it doesnt work.
  2. Try docker-compose run --rm --publish 9229:9229 --publish 4000:4000 -e NODE_ENV=development web node --inspect=0.0.0.0:9229 ./src/server.js instead.

@machikoyasuda machikoyasuda changed the title chore(development): add inspect-docker and inspect-brk-docker command chore(development): fix debugger command in README Jun 15, 2019
Copy link
Contributor

@focusaurus focusaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@focusaurus focusaurus merged commit 14e72bf into develop Jun 17, 2019
@focusaurus focusaurus deleted the machikoyasuda-patch-1 branch June 17, 2019 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants