Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix various eslint errors and warnings #684

Merged
merged 2 commits into from
Jun 5, 2020
Merged

chore: fix various eslint errors and warnings #684

merged 2 commits into from
Jun 5, 2020

Conversation

willopez
Copy link
Member

@willopez willopez commented Jun 5, 2020

Impact: critical
Type: refactor

Issue

The build is failing due to various eslint errors

Solution

fix errors and warnings

Testing

  1. A user should be able to perform a checkout and switch languages successfully.

@willopez willopez requested a review from mikemurray June 5, 2020 21:17
mikemurray
mikemurray previously approved these changes Jun 5, 2020
View reviewed changes
@mikemurray mikemurray dismissed their stale review June 5, 2020 22:33

Clicked too quickly

@mikemurray mikemurray merged commit 8954dcd into trunk Jun 5, 2020
@mikemurray mikemurray deleted the willopez-fix-eslint-errors branch June 5, 2020 22:45
@kieckhafer kieckhafer mentioned this pull request Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemurray mikemurray mikemurray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willopez @mikemurray