Revalidate index page, require instant revalidation if no shop is present during build #698
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Janus Reith [email protected]
Resolves #697
Impact: major
Type: feature|bugfix|performance|test|style|refactor|docs|chore
Issue
The shop is not present during the default CI build and no revalidation is set for that page. the shop id stays undefined and the query for catalog items is skipped.
Solution
Set a revalidation time for that page, check if no shop is present and return fallback values that will require immedate revalidation.
Testing
Additional context
As discussed with @willopez, we should somehow make sure that this is actually discouraged for production builds, as depoyments should not feature an initial render that is blank until the revalidated page is returned for subsequent requests.