Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node version to 18 #835

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ defaults: &defaults
- GITOPS_PR_WEBHOOK: "https://w603b5hwp1.execute-api.us-east-1.amazonaws.com/dev/pullrequests"
- GLOBAL_CACHE_VERSION: “v3”
docker:
- image: circleci/node:12-stretch
- image: cimg/node:18.10.0

jobs:
install-dependencies:
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
12.14.1
18.10.0
3 changes: 2 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
FROM node:12-alpine
FROM node:18.10.0-alpine

ARG NEXTJS_DOTENV

ENV NEXTJS_DOTENV=$NEXTJS_DOTENV
ENV NODE_OPTIONS=--openssl-legacy-provider

# hadolint ignore=DL3018
RUN apk --no-cache add bash curl less tini vim make
Expand Down
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,15 @@
"sideEffects": false,
"scripts": {
"dev": "echo 'Note: dev script has been renamed to start:dev' && yarn run start:dev",
"dev:latest": "echo 'Note: dev script has been renamed to start:dev:latest' && yarn run start:dev:latest",
"build": "yarn run build-clean && NODE_ENV=production IS_BUILDING_NEXTJS=1 next build",
"build:latest": "yarn run build-clean && NODE_OPTIONS=--openssl-legacy-provider NODE_ENV=production IS_BUILDING_NEXTJS=1 next build",
"build-clean": "rimraf .next",
"lint": "eslint .",
"lint:fix": "eslint . --fix",
"start": "NODE_ENV=production next start -p 4000",
"start:dev": "NODE_ENV=development next dev -p 4000",
"start:dev:latest": "NODE_OPTIONS=--openssl-legacy-provider NODE_ENV=development next dev -p 4000",
"test": "yarn run test:unit",
"test:ci": "yarn run test:unit --ci --runInBand --colors",
"test:unit": "NODE_ENV=jesttest jest",
Expand Down